fix: Don't use deprecated logger.warn#3552
Merged
Merged
Conversation
sentrivana
enabled auto-merge (squash)
September 20, 2024 12:06
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #3552 +/- ##
==========================================
- Coverage 84.51% 84.51% -0.01%
==========================================
Files 133 133
Lines 13837 13837
Branches 2927 2927
==========================================
- Hits 11695 11694 -1
Misses 1415 1415
- Partials 727 728 +1
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
logger.warn()is deprecated in favor oflogger.warning().We were using
logger.warn()in two places. I changed one todebugto not pollute folks' logs and the other one tologger.warning()since it's in the tests.